netdev - Re: [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating can device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A813963.10407@volkswagen.de>
Date:	Tue, 11 Aug 2009 11:26:59 +0200
From:	Oliver Hartkopp <oliver.hartkopp@...kswagen.de>
To:	Patrick McHardy <kaber@...sh.net>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Wolfgang Grandegger <wg@...ndegger.com>, dbaryshkov@...il.com,
	bugzilla-daemon@...zilla.kernel.org,
	bugme-daemon@...zilla.kernel.org,
	"Thuermann, Urs, Dr. (K-EFFI/I)" <urs.thuermann@...kswagen.de>,
	Lothar Wassmann <LW@...O-electronics.de>,
	netdev@...r.kernel.org
Subject: Re: [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating
 can device

Patrick McHardy wrote:
> Oliver Hartkopp wrote:
>   
>>>> I've got a nice oops when looking around new CAN code in kernel.
>>>>
>>>> root@...ux86:~# ip link add type can
>>>> [  713.113325] BUG: unable to handle kernel NULL pointer dereference
>>>> at (null)
>>>> [  713.114216] IP: [<c13eecab>] register_netdevice+0xab/0x420
>>>> ...
>>>>         
>> The problem is, that
>>
>> ip link add type can
>>
>> is not possible as you can not create 'real' CAN devices like can0,
>> can1, ...
>>
>> To create 'software CAN devices' like vcan0, vcan1, vcan2, ... we use
>>
>> ip link add type vcan
>>
>> see drivers/net/can/vcan.c
>>
>> ---
>>
>> For real hardware CAN devices the netlink interface is only used for the
>> configuration of already existing interfaces.
>> From a quick view on the rtnl_newlink() function in net/core/rtnetlink.c
>> i was not able to find any method to disallow the creation of 
>> interfaces, will say: How can a netlink user provide the information,
>> that he's not able to create new devices via netlink???
>>
>> @Patrick: Do you have an idea for this? Is it a new use-case for netlink
>> that needs to be implemented?
>>     
>
> You could add a ->newlink() function that unconditionally returns
> an error.
>
>   

Yes, that fixed it.

I created a can_newlink() function just returning -EINVAL ...

I'll cook a patch and send it on netdev (when it gets online again).

Thanks (to all),
Oliver

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html