netdev - Re: [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating can device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A813AEF.7000002@trash.net>
Date:	Tue, 11 Aug 2009 11:33:35 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Oliver Hartkopp <oliver.hartkopp@...kswagen.de>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Wolfgang Grandegger <wg@...ndegger.com>, dbaryshkov@...il.com,
	bugzilla-daemon@...zilla.kernel.org,
	bugme-daemon@...zilla.kernel.org,
	"Thuermann, Urs, Dr. (K-EFFI/I)" <urs.thuermann@...kswagen.de>,
	Lothar Wassmann <LW@...O-electronics.de>,
	netdev@...r.kernel.org
Subject: Re: [Bugme-new] [Bug 13954] New: Oops in rtnetlink code when creating
 can device

Oliver Hartkopp wrote:
>>> For real hardware CAN devices the netlink interface is only used for the
>>> configuration of already existing interfaces.
>>> From a quick view on the rtnl_newlink() function in net/core/rtnetlink.c
>>> i was not able to find any method to disallow the creation of
>>> interfaces, will say: How can a netlink user provide the information,
>>> that he's not able to create new devices via netlink???
>>>
>>> @Patrick: Do you have an idea for this? Is it a new use-case for netlink
>>> that needs to be implemented?
>>>     
>>
>> You could add a ->newlink() function that unconditionally returns
>> an error.
>>
>>   
> 
> Yes, that fixed it.
> 
> I created a can_newlink() function just returning -EINVAL ...
> 
> I'll cook a patch and send it on netdev (when it gets online again).

I'd suggest to use EOPNOTSUPP for consistency.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html