netdev - Re: [PATCH 2/2] drivers/net: fixed drivers that support netpoll use ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250868379.3937.279.camel@calx>
Date:	Fri, 21 Aug 2009 10:26:19 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	DDD <Dongdong.deng@...driver.com>
Cc:	David Miller <davem@...emloft.net>, Nicolas Pitre <nico@....org>,
	lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
	Jason Wessel <jason.wessel@...driver.com>
Subject: Re: [PATCH 2/2] drivers/net: fixed drivers that support netpoll
 use ndo_start_xmit()

On Fri, 2009-08-21 at 21:34 +0800, DDD wrote:
> The NETPOLL API requires that interrupts remain disabled in
> netpoll_send_skb(). The use of "A functions set" in the NETPOLL API
> callbacks causes the interrupts to get enabled and can lead to kernel
> instability.
> 
> The solution is to use "B functions set" to prevent the irqs from
> getting enabled while in netpoll_send_skb().
> 
> A functions set:
> local_irq_disable()/local_irq_enable()
> spin_lock_irq()/spin_unlock_irq()
> spin_trylock_irq()/spin_unlock_irq()
> 
> B functions set:
> local_irq_save()/local_irq_restore()
> spin_lock_irqsave()/spin_unlock_irqrestore()
> spin_trylock_irqsave()/spin_unlock_irqrestore()
> 
> Signed-off-by: Dongdong Deng <dongdong.deng@...driver.com>

Both of these look good to me, thanks.

Acked-by: Matt Mackall <mpm@...enic.com>

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html