lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 30 Aug 2009 22:19:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: krkumar2@...ibm.com Cc: netdev@...r.kernel.org Subject: Re: [RFC PATCH] sched: Fix resource limiting in pfifo_fast From: Krishna Kumar <krkumar2@...ibm.com> Date: Sun, 30 Aug 2009 11:53:44 +0530 > From: Krishna Kumar <krkumar2@...ibm.com> > > pfifo_fast_enqueue has this check: > if (skb_queue_len(list) < qdisc_dev(qdisc)->tx_queue_len) { > > which allows each band to enqueue upto tx_queue_len skbs for a > total of 3*tx_queue_len skbs. I am not sure if this was the > intention of limiting in qdisc. > > Patch compiled and 32 simultaneous netperf testing ran fine. Also: > # tc -s qdisc show dev eth2 > qdisc pfifo_fast 0: root bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 > Sent 16835026752 bytes 373116 pkt (dropped 0, overlimits 0 requeues 25) > rate 0bit 0pps backlog 0b 0p requeues 25 > > (I am taking next week off, so sorry for any delay in responding) > > Signed-off-by: Krishna Kumar <krkumar2@...ibm.com> This is probably just a thinko, nice catch. I think I'll apply this to net-next-2.6, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists