netdev - [PATCH] [net-next] tcp: avoid sending zero TSval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908312044.56235.opurdila@ixiacom.com>
Date:	Mon, 31 Aug 2009 20:44:56 +0300
From:	Octavian Purdila <opurdila@...acom.com>
To:	netdev@...r.kernel.org
Subject: [PATCH] [net-next] tcp: avoid sending zero TSval

Per RFC1323, zero TSecr is considered invalid. Thus we must avoid when
possible sending a zero TSval.

Currently, we use the least significant 32 bits of jiffies to fill in
TSval. But that can wrap around to zero (in 5 minutes after reboot,
and every 49 days after that in the worst case).

This patch approximate a wrap-around zero TSval to 1. This is better
then emitting a value which will be ignored.

Signed-off-by: Octavian Purdila <opurdila@...acom.com>
---
 net/ipv4/tcp_output.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

View attachment "71e6d2ae2ae12cfaf0d7cb8e010fd0c7f520874b.diff" of type "text/x-patch" (599 bytes)