netdev - Re: [PATCH 1/2] fec: fix recursive locking of mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090902.231701.09584427.davem@davemloft.net>
Date:	Wed, 02 Sep 2009 23:17:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerg@...pgear.com
Cc:	u.kleine-koenig@...gutronix.de, linux-rt-users@...r.kernel.org,
	ben@...adent.org.uk, kaber@...sh.net, s.hauer@...gutronix.de,
	Matt.Waddel@...escale.com, netdev@...r.kernel.org,
	tim01@...i.informatik.tu-darmstadt.de
Subject: Re: [PATCH 1/2] fec: fix recursive locking of mii_lock

From: Greg Ungerer <gerg@...pgear.com>
Date: Thu, 03 Sep 2009 11:16:16 +1000

> Hi Uwe,
> 
> Uwe Kleine-König wrote:
>> mii_discover_phy is only called by fec_enet_mii (via mip->mii_func).
>> So
>> &fep->mii_lock is already held and mii_discover_phy must not call
>> mii_queue which locks &fep->mii_lock, too.
>> This was noticed by lockdep:
 ...
>> 	...
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Cc: Greg Ungerer <gerg@...inux.org>
> 
> Looks good too.
> 
> Acked-by: Greg Ungerer <gerg@...inux.org>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html