netdev - Re: [PATCH 2/2] fec: don't enable irqs in hard irq context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090902.231709.224187980.davem@davemloft.net>
Date:	Wed, 02 Sep 2009 23:17:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gerg@...pgear.com
Cc:	u.kleine-koenig@...gutronix.de, linux-rt-users@...r.kernel.org,
	ben@...adent.org.uk, kaber@...sh.net, s.hauer@...gutronix.de,
	Matt.Waddel@...escale.com, netdev@...r.kernel.org,
	tim01@...i.informatik.tu-darmstadt.de
Subject: Re: [PATCH 2/2] fec: don't enable irqs in hard irq context

From: Greg Ungerer <gerg@...pgear.com>
Date: Thu, 03 Sep 2009 11:14:24 +1000

> Hi Uwe,
> 
> Uwe Kleine-König wrote:
>> fec_enet_mii, fec_enet_rx and fec_enet_tx are both only called by
>> fec_enet_interrupt in interrupt context.  So they must not use
>> spin_lock_irq/spin_unlock_irq.
>> This fixes:
>> 	WARNING: at kernel/lockdep.c:2140
>> 	trace_hardirqs_on_caller+0x130/0x194()
>> 	...
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> Cc: Greg Ungerer <gerg@...inux.org>
> 
> Looks good.
> 
> Acked-by: Greg Ungerer <gerg@...inux.org>

Applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html