netdev - RE: [PATCH 1/2] ibm_newemac: Add Support for MAL Interrupt Coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0CA0A16855646F4FA96D25A158E299D606FFE802@SDCEXCHANGE01.ad.amcc.com>
Date:	Mon, 21 Sep 2009 17:05:31 -0700
From:	"Prodyut Hazarika" <phazarika@...c.com>
To:	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>
Cc:	<netdev@...r.kernel.org>, "Feng Kan" <fkan@...c.com>,
	"Loc Ho" <lho@...c.com>, "Victor Gallardo" <vgallardo@...c.com>,
	<bhutchings@...arflare.com>, <linuxppc-dev@...ts.ozlabs.org>,
	<davem@...emloft.net>, <jwboyer@...ux.vnet.ibm.com>,
	<lada.podivin@...il.com>
Subject: RE: [PATCH 1/2] ibm_newemac: Add Support for MAL Interrupt Coalescing

Hi Ben,
Thanks again for your comments.

> Same goes with the SDR register definitions. Prefix them with the SOC
> name but don't make them conditionally compiled.

I will add the base address in the Device tree, and make all register
definitions based on offset from the base in the next version of this
patch.

> Also, this coalescing option, while it makes sense to have a CONFIG
> option to compile in the support for it or not, the choice to use
> coalescing or not should be done at runtime. Same goes with the
various
> thresholds which should be runtime configurable.

Thanks for this comment. I will hookup ethtool with the EMAC driver, but
the MAL driver will come up with default coalesce options (as defined in
the appropriate defconfig file). The user will be able to change these
parameters as needed using ethtool.

I will get all the changes in place in the next version of this patch.

Thanks
Prodyut

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html