netdev - Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253689036.4458.22.camel@johannes.local>
Date:	Wed, 23 Sep 2009 08:57:16 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	davem@...emloft.net, linville@...driver.com,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	linux-mmc@...r.kernel.org, yi.zhu@...el.com,
	inaky.perez-gonzalez@...el.com, cindy.h.kao@...el.com,
	guy.cohen@...el.com, ron.rindjunsky@...el.com
Subject: Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top
 driver.

On Wed, 2009-09-23 at 02:38 +0300, Tomas Winkler wrote:

> +config IWMC3200TOP
> +        tristate "Intel Wireless MultiCom Top Driver"
> +        depends on MMC && EXPERIMENTAL
> +        select FW_LOADER
> +	---help---
> +	  Intel Wireless MultiCom 3200 Top driver is responsible for
> +	  for firmware load and enabled coms enumeration

This seems like the wrong approach to me.

To me, it seems like you have a device that contains an internal bus and
allows bus enumeration. Typically, we would surface that bus in the
driver/device model and allow sub-drivers to bind to that by way of
exposing the internal bus, like e.g. drivers/ssb/.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)