netdev - Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ba2fa240909230023v17fe2b49v4981d464dba469ed@mail.gmail.com>
Date:	Wed, 23 Sep 2009 10:23:59 +0300
From:	Tomas Winkler <tomasw@...il.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	davem@...emloft.net, linville@...driver.com,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	linux-mmc@...r.kernel.org, yi.zhu@...el.com,
	inaky.perez-gonzalez@...el.com, cindy.h.kao@...el.com,
	guy.cohen@...el.com, ron.rindjunsky@...el.com
Subject: Re: [PATCH 1/3] iwmc3200top: Add Intel Wireless MultiCom 3200 top 
	driver.

On Wed, Sep 23, 2009 at 9:57 AM, Johannes Berg
<johannes@...solutions.net> wrote:
> On Wed, 2009-09-23 at 02:38 +0300, Tomas Winkler wrote:
>
>> +config IWMC3200TOP
>> +        tristate "Intel Wireless MultiCom Top Driver"
>> +        depends on MMC && EXPERIMENTAL
>> +        select FW_LOADER
>> +     ---help---
>> +       Intel Wireless MultiCom 3200 Top driver is responsible for
>> +       for firmware load and enabled coms enumeration
>
> This seems like the wrong approach to me.
>
> To me, it seems like you have a device that contains an internal bus and
> allows bus enumeration. Typically, we would surface that bus in the
> driver/device model and allow sub-drivers to bind to that by way of
> exposing the internal bus, like e.g. drivers/ssb/.

>From HW perspective your assumption is not exactly correct. All the
devices are visible on the SDIO bus but they are not operational
(probe won't succeed) until TOP download the firmware and kicks the
devices. From SW perspective to create another bus layer is an option.
I'm not sure if it's not more complicated one.

Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html