[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090924213039.GA15904@oksana.dev.rtsoft.ru>
Date: Fri, 25 Sep 2009 01:30:39 +0400
From: Anton Vorontsov <avorontsov@...mvista.com>
To: "Rafael J. Wysocki" <rjw@...k.pl>
Cc: David Miller <davem@...emloft.net>,
linux-pm@...ts.linux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] 3c59x: Get rid of "Trying to free already-free IRQ"
On Thu, Sep 24, 2009 at 10:30:33PM +0200, Rafael J. Wysocki wrote:
> On Thursday 24 September 2009, Anton Vorontsov wrote:
> > Following trace pops up if we try to suspend with 3c59x ethernet NIC
> > brought down:
>
> Patch looks good, but IMO it'd be a little effort to convert the driver to
> dev_pm_ops while you're at it (please see r8169 for a working example).
I'd like to avoid putting irrelevant stuff into bugfixes.
Apart from delights as bisecting and revert-only-offending-piece,
keeping bugfixes small and self-sufficient helps to back-port the
fixes to stable/distro kernels. Think of not so old kernels that
don't have dev_pm_ops.
Converting this driver (and others that I'm interested in) to
dev_pm_ops is on my todo list though.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists