netdev - Re: [PATCH] ax25: Add missing dev_put in ax25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090928.122638.52076650.davem@davemloft.net>
Date:	Mon, 28 Sep 2009 12:26:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ralf@...ux-mips.org
Cc:	jarkao2@...il.com, f6bvp@...e.fr, bernard.pidoux@...c.fr,
	netdev@...r.kernel.org, linux-hams@...r.kernel.org
Subject: Re: [PATCH] ax25: Add missing dev_put in ax25_setsockopt

From: Ralf Baechle <ralf@...ux-mips.org>
Date: Mon, 28 Sep 2009 13:53:13 +0100

> ax25_setsockopt SO_BINDTODEVICE is missing a dev_put call in case of
> success.  Re-order code to fix this bug.  While at it also reformat two
> lines of code to comply with the Linux coding style.
> 
> Initial patch by Jarek Poplawski <jarkao2@...il.com>.
> 
> Reported-by: Bernard Pidoux F6BVP <f6bvp@...e.fr>
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>
> 
> ---
> Counter-proposal.  Reordering all the code avoids the need for a 2nd dev_put
> and is more readable.

Looks good to me, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html