netdev - Re: [PATCH] get rid of read/write lock in gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090928.124226.27020404.davem@davemloft.net>
Date:	Mon, 28 Sep 2009 12:42:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH] get rid of read/write lock in gen_estimator

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 28 Sep 2009 20:50:28 +0200

> Stephen Hemminger a écrit :
>> Don't need a read/write lock here sinc there already is a spin lock that
>> is being acquired.
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
 ...
>> @@ -270,9 +265,9 @@ void gen_kill_estimator(struct gnet_stat
>>  	while ((e = gen_find_node(bstats, rate_est))) {
>>  		rb_erase(&e->node, &est_root);
>>  
>> -		write_lock_bh(&est_lock);
>> +		spin_lock(e->stats_lock);
> 
> Are you sure _bh() variant is not needed here ?

Right, that need to be fixed to be spin_lock_bh() and spin_unlock_bh()
in the next hunk.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html