netdev - Re: [PATCH] TCPCT-1: adding a sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091002.154808.137771153.davem@davemloft.net>
Date:	Fri, 02 Oct 2009 15:48:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	william.allen.simpson@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] TCPCT-1: adding a sysctl

From: William Allen Simpson <william.allen.simpson@...il.com>
Date: Fri, 02 Oct 2009 17:46:12 -0400

> Andi Kleen wrote:
>> William Allen Simpson <william.allen.simpson@...il.com> writes:
>>> Any suggestions for improvement?  Or general approval?
>> The patch seems incomplete, can't find callers for most of the new
>> functions.
>> 
> Ummm, I was following the suggested practice of breaking it into
> smaller
> pieces for review.  This is just the control functions and headers.
> I've
> actually completed most of the port, and am champing at the bit.

We can't review the helper functions and infrastructure properly until
we can see how they are actually used.

Seeing how they are used shows us how well they are designed.

Otherwise asking for a is absolutely pointless as we have no context
in which to judge the code you're showing us.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html