netdev - Re: [PATCH] TCPCT-1: adding a sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091002.232653.140263722.davem@davemloft.net>
Date:	Fri, 02 Oct 2009 23:26:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	william.allen.simpson@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] TCPCT-1: adding a sysctl

From: William Allen Simpson <william.allen.simpson@...il.com>
Date: Fri, 02 Oct 2009 20:32:09 -0400

> David Miller wrote:
>> From: William Allen Simpson <william.allen.simpson@...il.com>
>>> Ummm, I was following the suggested practice of breaking it into
>>> smaller
>>> pieces for review.  This is just the control functions and headers.
>>> I've
>>> actually completed most of the port, and am champing at the bit.
>> We can't review the helper functions and infrastructure properly until
>> we can see how they are actually used.
>> Seeing how they are used shows us how well they are designed.
>> Otherwise asking for a is absolutely pointless as we have no context
>> in which to judge the code you're showing us.
>> 
> Thanks.  I'd hand-split my code into much smaller patches for review.
> Now, I know there are patches that are *too* small....

It's not that the patches are too small, you totally misunderstand me.

The problem is that you have to post all of the patches as a set which
can be reviewed as a unit.  The ones the use the new functions as well
as the ones that add them.

It also helps if you mention in the commit message things like
"These helper functions will be used in a subsequent change which
does ..."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html