netdev - Re: [PATCH] [CAIF-RFC 0/8-v2] CAIF Protocol Stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091012.024149.61074790.davem@davemloft.net>
Date:	Mon, 12 Oct 2009 02:41:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sjur.brandeland@...ricsson.com
Cc:	netdev@...r.kernel.org, stefano.babic@...ic.homelinux.org,
	randy.dunlap@...cle.com, kim.xx.lilliestierna@...ricsson.com,
	christian.bejram@...ricsson.com, daniel.martensson@...ricsson.com
Subject: Re: [PATCH] [CAIF-RFC 0/8-v2] CAIF Protocol Stack

From: sjur.brandeland@...ricsson.com
Date: Fri, 09 Oct 2009 15:39:23 +0200

> From: Sjur Braendeland <sjur.brandeland@...ricsson.com>
> 
> This is the second version of the CAIF patch set.
> The patch set is compiled on 386 for 2.6.31.
> All feedback is apreciated.

There is a lot of coding style issues here I'd like you to
address in your next submission.

Comments are formatted in several places like this:

/*
*
*
*/

It should be:

/*
 *
 *
 */

Also often there are tons of extraneous empty lines in the source
files.  Particularly right after the comment at the top of the
source file.  For example include/net/caif/generic/cfcnfg.h
there is the top comment (which needs to be fixed as described
above) and then 8 empty lines before the #ifndef CFCNFG_H_

That's rediculious, just have one empty line there seperating things.

Seriously, you should be able to just scan over your patch and see all
of these oddities.  They jumped right out at me.  Please clean them
up.

Thank you.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html