netdev - Re: [PATCH netnext-2.6] bonding: change bond_create_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2009 00:45:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.2p.debian@...e.fr
Cc:	fubar@...ibm.com, netdev@...r.kernel.org,
	bonding-devel@...ts.sourceforge.net, rakib.mullick@...il.com
Subject: Re: [PATCH netnext-2.6] bonding: change bond_create_proc_entry()
 to return void

From: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
Date: Sat, 10 Oct 2009 22:41:47 +0200

> The function bond_create_proc_entry is currently of type int.
> 
> Two versions of this function exist:
> 
> The one in the ifdef CONFIG_PROC_FS branch always return 0.
> The one in the else branch (which is empty) return nothing.
> 
> When CONFIG_PROC_FS is undef, this cause the following warning:
> 
> drivers/net/bonding/bond_main.c: In function `bond_create_proc_entry':
> drivers/net/bonding/bond_main.c:3393: warning: control reaches end of
> non-void function
> 
> No caller of this function use the returned value.
> 
> So change the returned type from int to void and remove the
> useless return 0; .
> 
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
> Reported-by: Rakib Mullick <rakib.mullick@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html