netdev - Re: [PATCH -mm] connector: Passing required parameter for function cn_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9df5fa10910122227r710d6782m89fc9ec4273487b8@mail.gmail.com>
Date:	Tue, 13 Oct 2009 11:27:49 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org, zbr@...emap.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] connector: Passing required parameter for function 
	cn_add_callback.

On 10/12/09, David Miller <davem@...emloft.net> wrote:
> From: Rakib Mullick <rakib.mullick@...il.com>
>  Date: Mon, 12 Oct 2009 08:44:33 +0600
>
>
>  >   */
>  > -static void cn_proc_mcast_ctl(struct cn_msg *msg)
>  > +static void cn_proc_mcast_ctl(struct cn_msg *msg, struct
>  > netlink_skb_parms *nsp)
>
>
> Your patches are unusable because your email client corrupts the
>  patch, here you can see it is splitting up long lines.
>
>  Please fix this up and resubmit.
Oops..... sorry for that. This is the second time I'm facing this
problem. I'll try to fix it.
I'm resubmitting the patch. Here I've recreate the patch to split the
line into two.
And it just reaches its 80 line mark. Hopefully it will be okay.

Thanks,

----
Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>

--- linus/drivers/connector/cn_proc.c	2009-10-09 17:38:22.000000000 +0600
+++ rakib/drivers/connector/cn_proc.c	2009-10-13 12:29:37.000000000 +0600
@@ -225,9 +225,11 @@ static void cn_proc_ack(int err, int rcv

 /**
  * cn_proc_mcast_ctl
- * @data: message sent from userspace via the connector
+ * @msg: message sent from userspace via the connector
+ * @nsp: remains unused but we need it to keep it
  */
-static void cn_proc_mcast_ctl(struct cn_msg *msg)
+static void cn_proc_mcast_ctl(struct cn_msg *msg,
+				struct netlink_skb_parms *nsp)
 {
 	enum proc_cn_mcast_op *mc_op = NULL;
 	int err = 0;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html