netdev - Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091014.151025.83161886.davem@davemloft.net>
Date:	Wed, 14 Oct 2009 15:10:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	grant.likely@...retlab.ca
Cc:	linuxppc-dev@...ts.ozlabs.org, netdev@...r.kernel.org,
	bones@...retlab.ca
Subject: Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

From: Grant Likely <grant.likely@...retlab.ca>
Date: Wed, 14 Oct 2009 11:43:43 -0600

> From: John Bonesio <bones@...retlab.ca>
> 
> The MDIO bus cannot be accessed at interrupt context, but on an FEC
> error, the fec_mpc52xx driver reset function also tries to reset the
> PHY.  Since the error is detected at IRQ context, and the PHY functions
> try to sleep, the kernel ends up panicking.
> 
> Resetting the PHY on an FEC error isn't even necessary.  This patch
> solves the problem by removing the PHY reset entirely.
> 
> Signed-off-by: John Bonesio <bones@...retlab.ca>
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html