netdev - Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40910141232nab95d4al13016d4dc4fbc6cf@mail.gmail.com>
Date:	Wed, 14 Oct 2009 13:32:54 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Wolfgang Grandegger <wg@...ndegger.com>
Cc:	linuxppc-dev@...ts.ozlabs.org, netdev@...r.kernel.org,
	davem@...emloft.net, John Bonesio <bones@...retlab.ca>
Subject: Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

On Wed, Oct 14, 2009 at 1:11 PM, Wolfgang Grandegger <wg@...ndegger.com> wrote:
> Grant Likely wrote:
>> From: John Bonesio <bones@...retlab.ca>
>>
>> The MDIO bus cannot be accessed at interrupt context, but on an FEC
>> error, the fec_mpc52xx driver reset function also tries to reset the
>> PHY.  Since the error is detected at IRQ context, and the PHY functions
>> try to sleep, the kernel ends up panicking.
>>
>> Resetting the PHY on an FEC error isn't even necessary.  This patch
>> solves the problem by removing the PHY reset entirely.
>
> There is also no need to free and re-allocate the RX buffers in
> mpc52xx_fec_reset().

Write and test a patch for me!  :-)

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html