netdev - Re: [Patch-next] Fix the size overflow of addrconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200910142114.53845.opurdila@ixiacom.com>
Date:	Wed, 14 Oct 2009 21:14:48 +0300
From:	Octavian Purdila <opurdila@...acom.com>
To:	David Miller <davem@...emloft.net>
Cc:	cratiu@...acom.com, jin.dongming@...css.fujitsu.com,
	kaneshige.kenji@...fujitsu.com, seto.hidetoshi@...fujitsu.com,
	netdev@...r.kernel.org
Subject: Re: [Patch-next] Fix the size overflow of addrconf_sysctl array

On Tuesday 13 October 2009 13:45:09 you wrote:
> From: Cosmin Ratiu <cratiu@...acom.com>
> Date: Fri, 9 Oct 2009 16:11:14 +0300
> 
> > Shouldn't this be changed too then?
> >
> > Or better yet, wouldn't a change that eliminates the need of adding a new
> > option in two separate places be useful?
> 
> Yes, it's crummy how things work now, indeed.
> 
> > I see the only use for that DEVCONF enum is to dump the settings via
> > netlink. Wouldn't a memcpy suffice?
> 
> It should be.
> 

I've taken a look at this and it seems the current way of doing it is really 
required as we need to preserve userspace ABI across different CONFIG_ 
settings.

tavi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html