lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200911061604.21465.lgrijincu@ixiacom.com> Date: Fri, 6 Nov 2009 16:04:21 +0200 From: Lucian Adrian Grijincu <lgrijincu@...acom.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, opurdila@...acom.com Subject: Re: [PATCH 1/2] udp: cleanup __udp4_lib_mcast_deliver În data de Vin 06 Noi 2009 10:42:15 David Miller a scris: > Getting rid of the useless return value is fine, but the > new do{}while() loop et al. is less readable to me. It's not new. I just moved it: previously: if(cond) { do {} while() } else {return} now: if (!cond) return; do {} while {} Also this moves a consume_skb() from a path protected by spin locks. As far as I understand it, the spin locks protect the hslot, and freeing the skb does not walk/change or interact with the hslot in any way. -- Lucian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists