netdev - Re: [PATCH net-next-2.6] net: sock_bindtodevice() RCU-ification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AF3CB8B.2090206@gmail.com>
Date:	Fri, 06 Nov 2009 08:08:59 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: sock_bindtodevice() RCU-ification

David Miller a écrit :
> From: David Miller <davem@...emloft.net>
> Date: Thu, 05 Nov 2009 21:08:30 -0800 (PST)
> 
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Wed, 04 Nov 2009 23:36:44 +0100
>>
>>> Avoid dev_hold()/dev_put() in sock_bindtodevice()
>>>
>>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> Applied to net-next-2.6, thanks.
> 
> Eric I had to add the following patch to cure a build
> warning after this, just FYI:
> 
> net: Fix build warning in sock_bindtodevice().
> 
> net/core/sock.c: In function 'sock_setsockopt':
> net/core/sock.c:396: warning: 'index' may be used uninitialized in this function
> net/core/sock.c:396: note: 'index' was declared here
> 
> GCC can't see that all paths initialize index, so just
> set it to the default (0) and eliminate the specific
> code block that handles the null device name string.
> 

Thanks David, which gcc version are you using ?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html