netdev - Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091106070736.GA12697@verge.net.au>
Date:	Fri, 6 Nov 2009 18:07:46 +1100
From:	Simon Horman <horms@...ge.net.au>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Liran Liss <liranl@...lanox.co.il>,
	Or Gerlitz <or.gerlitz@...il.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.co.il>,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	Tziporet Koren <tziporet@...lanox.co.il>
Subject: Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves

On Thu, Nov 05, 2009 at 10:08:58PM -0800, Roland Dreier wrote:
> 
>  > > igb uses the full output of random_ether_addr().  I'd be fine with
>  > > that.  However setting the OUI means you only get 24 bits of randomness
>  > > which makes a collision a lot more likely.
>  > 
>  > IIRC that was precisely why the OUI isn't used for the igb driver.
>  > 
>  > Perhaps some infrastructure (by which I mean a random_mac() function)
>  > is warranted so at least this discussion can be concentrated around that
>  > rather than repeating it for each driver that needs random mac addresses.
> 
> What would be the difference between random_mac() and the existing
> random_ether_addr() function?

Sorry, I was mistaken. igb is using random_ether_addr(),
which is what I had in mind.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html