netdev - Re: [PATCH net-next-2.6] bonding: fix 802.3ad standards compliance error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6802.1258156053@death.nxdomain.ibm.com>
Date:	Fri, 13 Nov 2009 15:47:33 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Stephen Hemminger <shemminger@...tta.com>
cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	martin@...r6.com
Subject: Re: [PATCH net-next-2.6] bonding: fix 802.3ad standards compliance error

Stephen Hemminger <shemminger@...tta.com> wrote:

>On Fri, 13 Nov 2009 15:13:01 -0800
>Jay Vosburgh <fubar@...ibm.com> wrote:
>
>> +	// check if all parameters are alike
>> +	if (((ntohs(lacpdu->partner_port) == port->actor_port_number) &&
>> +	     (ntohs(lacpdu->partner_port_priority) == port->actor_port_priority) &&
>> +	     !MAC_ADDRESS_COMPARE(&(lacpdu->partner_system), &(port->actor_system)) &&
>> +	     (ntohs(lacpdu->partner_system_priority) == port->actor_system_priority) &&
>> +	     (ntohs(lacpdu->partner_key) == port->actor_oper_port_key) &&
>> +	     ((lacpdu->partner_state & AD_STATE_AGGREGATION) == (port->actor_oper_port_state & AD_STATE_AGGREGATION))) ||
>> +	    // or this is individual link(aggregation == FALSE)
>
>I know the code here doesn't follow kernel style, but please don't
>add more C99 comments or overly long lines.

	I didn't, really; I moved the function up in the file rather
than adding a forward declaration.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html