netdev - Re: [PATCH net-next-2.6] bonding: fix 802.3ad standards compliance error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 15 Nov 2009 22:22:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	netdev@...r.kernel.org, martin@...r6.com
Subject: Re: [PATCH net-next-2.6] bonding: fix 802.3ad standards compliance
 error

From: Jay Vosburgh <fubar@...ibm.com>
Date: Fri, 13 Nov 2009 15:13:01 -0800

> 	The language of 802.3ad 43.4.9 requires the "recordPDU" function
> to, in part, compare the Partner parameter values in a received LACPDU
> to the stored Actor values.  If those match, then the Partner's
> synchronization state is set to true.
> 
> 	The current 802.3ad implementation is performing these steps out
> of order; first, the synchronization check is done, then the paramters are
> checked to see if they match (the synch check being done against a match
> check of a prior LACPDU).  This causes delays in establishing aggregators
> in some circumstances.
 ...
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied, thanks.

A patch that cleans up all of the non-standard stuff in these
sources, as pointed out by Stephen, would be most welcome.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html