netdev - Re: [net-next-2.6 PATCH v6 4/7 RFC] TCPCT part 1d: define TCP cookie option, extend existing struct's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AFD8421.6090003@gmail.com>
Date:	Fri, 13 Nov 2009 11:06:57 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [net-next-2.6 PATCH v6 4/7 RFC] TCPCT part 1d: define TCP cookie
 option, extend existing struct's

Eric Dumazet wrote:
> +/**
> + * A tcp_sock contains a pointer to the current value, and this is cloned to
> + * the tcp_timewait_sock.
> + *
> + * @cookie_pair:	variable data from the option exchange.
> + *
> + * @cookie_desired:	user specified tcpct_cookie_desired.  Zero
> + *			indicates default (sysctl_tcp_cookie_size).
> + *			After cookie sent, remembers size of cookie.
> + *			Range 0, TCP_COOKIE_MIN to TCP_COOKIE_MAX.
> + *
> + * @s_data_desired:	user specified tcpct_s_data_desired.  When the
> + *			constant payload is specified (@s_data_constant),
> + *			holds its length instead.
> + *			Range 0 to TCP_MSS_DESIRED.
> + *
> + * @s_data_payload:	constant data that is to be included in the
> + *			payload of SYN or SYNACK segments when the
> + *			cookie option is present.
> + */
> 
> Thanks for this kerneldoc William ;)
> 
> But header should be :
> /**
>  *	struct tcp_cookie_values - Some description...
> 
Botheration.  Just unlucky in following another example (again).

A private message suggests including the initialization code here
(instead of part 1f) to avoid some page flipping.  Done.

Here's my revised attempt (untested).  Any technical corrections?





View attachment "TCPCT+1d6+.patch" of type "text/plain" (10957 bytes)