netdev - Re: [net-next-2.6 PATCH v6 2/7 RFC] TCPCT part 1b: generate Responder Cookie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AFD728F.4030206@gmail.com>
Date:	Fri, 13 Nov 2009 09:51:59 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [net-next-2.6 PATCH v6 2/7 RFC] TCPCT part 1b: generate Responder
 Cookie

Joe Perches wrote:
> Rather than using stack, could you use
> u32 *secrets = &tcp_secret_secondary->secrets[0];
> 
That was because I thought it needed to be copied after the unlock.
Since Eric says it can be inside the locked path, I can do away with
that entirely, and just use the result (bakery) pointer itself.  Saves a
memcpy, too.

Here's my revised attempt (untested).  Any other technical corrections?

View attachment "TCPCT+1b6+.patch" of type "text/plain" (6856 bytes)