lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Nov 2009 19:26:02 +0100 From: Wolfgang Grandegger <wg@...ndegger.com> To: Wolfram Sang <w.sang@...gutronix.de> CC: Grant Likely <grant.likely@...retlab.ca>, socketcan-core@...ts.berlios.de, netdev@...r.kernel.org, David Miller <davem@...emloft.net>, linuxppc-dev@...abs.org Subject: Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan Wolfram Sang wrote: > Hi Grant, > > Wolfgang commented on some points already, I will pick up the other remarks, > just one question: > >>> + clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL); >>> + if (clk_src && strcmp(clk_src, "ip") == 0) >> Should protect against non-null. strncmp() maybe? > > "ip" is null-terminated, or what do you mean? Imagine somebody defines: fsl,mscan-clk-src = <0xbaeee>; Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists