netdev - Re: [PATCH] ixgbe: Fixing EEH handler to handle more than one error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091116.235209.227827212.davem@davemloft.net>
Date:	Mon, 16 Nov 2009 23:52:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	leitao@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH] ixgbe: Fixing EEH handler to handle more than one error

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Mon, 16 Nov 2009 11:01:13 -0800 (Pacific Standard Time)

> On Sun, 15 Nov 2009, David Miller wrote:
> 
>> From: leitao@...ux.vnet.ibm.com
>> Date: Tue, 10 Nov 2009 13:37:47 -0500
>> 
>> > After commmit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff EEH breaks
>> > after the second error, since it calls pci_restore_state()
>> > but it returns 0, since pci->state_saved is false.
>> > 
>> > So, this patch just call pci_save_state() after pci_restore_state().
>> > 
>> > Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>
>> 
>> Intel folks, are you integrating or looking at this patch?
> 
> This patch looks correct and makes sense to me.  I'm going to ACK it now, 
> but we'll still pull it in and test it.  If we see any issues, we'll 
> report them with possible fixes.  But at this point, I think this patch is 
> fine.
> 
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html