netdev - Re: [PATCH] ppp: fix BUG on non-linear SKB (multilink receive)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091116.235254.148428748.davem@davemloft.net>
Date:	Mon, 16 Nov 2009 23:52:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ben@...servers.co.uk
Cc:	paulus@...ba.org, netdev@...r.kernel.org, linux-ppp@...r.kernel.org
Subject: Re: [PATCH] ppp: fix BUG on non-linear SKB (multilink receive)

From: Ben McKeegan <ben@...servers.co.uk>
Date: Mon, 16 Nov 2009 13:44:25 +0000 (GMT)

> PPP does not correctly call pskb_may_pull() on all necessary receive paths
> before reading the PPP protocol, thus causing PPP to report seemingly
> random 'unsupported protocols' and eventually trigger BUG_ON(skb->len <
> skb->data_len) in skb_pull_rcsum() when receiving multilink protocol in
> non-linear skbs.
> 
> ppp_receive_nonmp_frame() does not call pskb_may_pull() before reading the
> protocol number.  For the non-mp receive path this is not a problem, as
> this check is done in ppp_receive_frame().  For the mp receive path,
> ppp_mp_reconstruct() usually copies the data into a new linear skb.
> However, in the case where the frame is made up of a single mp fragment,
> the mp header is pulled and the existing skb used.  This skb was then
> passed to ppp_receive_nonmp_frame() without checking if the encapsulated
> protocol header could safely be read.
> 
> Signed-off-by: Ben McKeegan <ben@...servers.co.uk>

Applied but:

> +	while ((skb = ppp_mp_reconstruct(ppp))) {
> +	  	if (pskb_may_pull(skb, 2))

There is a mix of space and tab characters leading up to
the "if (pskb_may_pull" there, I fixed it up but please
take care of such trivial issues before submitting your
patch next time.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html