netdev - Re: [PATCH 17/11]Optimize the upload speed for PPP connection.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B0278D9.6030806@gmail.com>
Date:	Tue, 17 Nov 2009 05:20:09 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	huananhu@...wei.com
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/11]Optimize the upload speed for PPP connection.

David Miller wrote:
> Your patch is broken, please don't wate my time like this.
> 
> + git apply --check --whitespace=error-all diff
> error: patch failed: drivers/net/ppp_async.c:36
> error: drivers/net/ppp_async.c: patch does not apply
> 
What David may have meant, had he followed Documentation/ManagementStyle
or had any project management skills what-so-ever, is that you need to
follow Documentation/SubmittingPatches more carefully.

Look at 15) The canonical patch format

[PATCH 17/11] makes no sense, you don't have 11 patches, and the 17th
patch of 11 can never exist.

Need a better "subsystem: summary phrase", perhaps
   "net: PPP buffer too small for higher speed connections"

A marker line containing simply "---".

And your trailer boilerplate badly breaks the system, because it's
missing the SMTP email standard "--" line in front of it.

You'll get nicer formatting with 'git format-patch -o ~ HEAD~1' after you
do a 'git commit -a' on your git tree.

It takes some time, even for a simple 1 line fix like this....

Hope that helps.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html