netdev - Re: [RFC-PATCH] libiscsi dhcp handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b263e5900911200529n1c002097q48a625d1bcda4db6@mail.gmail.com>
Date:	Fri, 20 Nov 2009 15:29:24 +0200
From:	Dan Carpenter <error27.lkml@...il.com>
To:	Rakesh Ranjan <rakesh@...lsio.com>
Cc:	David Miller <davem@...emloft.net>, michaelc@...wisc.edu,
	open-iscsi@...glegroups.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, James.Bottomley@...e.de,
	kxie@...lsio.com
Subject: Re: [RFC-PATCH] libiscsi dhcp handler

On 11/16/09, Rakesh Ranjan <rakesh@...lsio.com> wrote:
> David Miller wrote:
>> From: Rakesh Ranjan <rakesh@...lsio.com>
>> Date: Mon, 16 Nov 2009 18:41:49 +0530
>>
>>> Herein attached patches to support dhcp based provisioning for iSCSI
>>> offload capable cards. I have made dhcp code as generic as possible,
>>> please go through the code. Based on the feedback I will submit final
>>> version of these patches.
>>
>> You can't really add objects to the build before the patch that
>> adds the source for that object.
>>
>
> Hi david,
>
> Fixed patch attached.
>
> Regards
> Rakesh Ranjan
>

The header file changes cause warnings in allmodconfig.

   CC [M]  drivers/scsi/be2iscsi/be_iscsi.o
+In file included from drivers/scsi/be2iscsi/be_iscsi.c:21:
+include/scsi/libiscsi.h:445: warning: ‘struct net_device’ declared
inside parameter list
+include/scsi/libiscsi.h:445: warning: its scope is only this
definition or declaration, which is probably not what you want
+include/scsi/libiscsi.h:447: warning: ‘struct sk_buff’ declared
inside parameter list
+include/scsi/libiscsi.h:447: warning: ‘struct net_device’ declared
inside parameter list

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html