netdev - Re: [RFC-PATCH] libiscsi dhcp handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091121081301.GA17766@bicker>
Date:	Sat, 21 Nov 2009 10:13:01 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Dan Carpenter <error27.lkml@...il.com>
Cc:	Rakesh Ranjan <rakesh@...lsio.com>,
	David Miller <davem@...emloft.net>, michaelc@...wisc.edu,
	open-iscsi@...glegroups.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, James.Bottomley@...e.de,
	kxie@...lsio.com
Subject: Re: [RFC-PATCH] libiscsi dhcp handler

On Fri, Nov 20, 2009 at 03:29:24PM +0200, Dan Carpenter wrote:
> On 11/16/09, Rakesh Ranjan <rakesh@...lsio.com> wrote:
> > David Miller wrote:
> >> From: Rakesh Ranjan <rakesh@...lsio.com>
> >> Date: Mon, 16 Nov 2009 18:41:49 +0530
> >>
> >>> Herein attached patches to support dhcp based provisioning for iSCSI
> >>> offload capable cards. I have made dhcp code as generic as possible,
> >>> please go through the code. Based on the feedback I will submit final
> >>> version of these patches.
> >>
> >> You can't really add objects to the build before the patch that
> >> adds the source for that object.
> >>
> >
> > Hi david,
> >
> > Fixed patch attached.

+       spin_unlock(&rcv_lock);                                                                                              
+                                                                                                                            
+drop:                                                                                                                       
+       kfree(pskb);                                                                                                         

This should be kfree_skb(pskb)

+out:                                                                                                                        
+       return rc;                                                                                                           
+}                                                                                                                           
+EXPORT_SYMBOL(libiscsi_ipconfig_recv);                                                                                      

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html