lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Nov 2009 09:20:17 -0800 (PST) From: David Miller <davem@...emloft.net> To: william.allen.simpson@...il.com Cc: netdev@...r.kernel.org Subject: Re: [net-next-2.6 PATCH v7 1/7 RFC] TCPCT part 1a: add request_values parameter for sending SYNACK From: William Allen Simpson <william.allen.simpson@...il.com> Date: Fri, 20 Nov 2009 09:12:13 -0500 > - if (tcp_v6_send_synack(sk, req)) > - goto drop; > + if (tcp_v6_send_synack(sk, req, NULL) > + || want_cookie) > + goto drop_and_free; Please fix the coding style here, the "||" belongs at the end of the previous line, not at the start of the next one. Also, since it will all fit one one line anyways, please make it that way: if (tcp_v6_send_synack(sk, req, NULL) || want_cookie) Some of us still use 80x25 terminals to read code :-) I think you've been asked to fix this specific kinds of cases up before. Thanks a lot. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists