netdev - Re: [net-next-2.6 PATCH v7 5/7 RFC] TCPCT part 1e: implement socket option TCP_COOKIE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Nov 2009 09:26:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	william.allen.simpson@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH v7 5/7 RFC] TCPCT part 1e: implement
 socket option TCP_COOKIE_TRANSACTIONS

From: William Allen Simpson <william.allen.simpson@...il.com>
Date: Fri, 20 Nov 2009 09:48:12 -0500

> +		if (ctd.tcpct_used > sizeof(ctd.tcpct_value)
> +		 || ctd.tcpct_s_data_desired > TCP_MSS_DESIRED)
> +			return -EINVAL;

Please fix this conditional coding style.

> +		} else if ((0x1 & ctd.tcpct_cookie_desired)
> +			|| ctd.tcpct_cookie_desired > TCP_COOKIE_MAX
> +			|| ctd.tcpct_cookie_desired < TCP_COOKIE_MIN) {
> +			return -EINVAL;

Same here.

> +		if (ctd.tcpct_used > 0
> +		 || (tp->cookie_values == NULL
> +		  && (sysctl_tcp_cookie_size > 0
> +		   || ctd.tcpct_cookie_desired > 0
> +		   || ctd.tcpct_s_data_desired > 0))) {

Please fix the conditional coding style, and the alignment of
the lines, it's not right here.

> +		ctd.tcpct_flags = (tp->rx_opt.cookie_in_always
> +				   ? TCP_COOKIE_IN_ALWAYS : 0)
> +				| (tp->rx_opt.cookie_out_never
> +				   ? TCP_COOKIE_OUT_NEVER : 0);

"?" should be at end of previous line not at beginning of
next one, please fix this up.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html