netdev - Re: [net-next-2.6 PATCH v7 6/7 RFC] TCPCT part 1f: Initiator Cookie => Responder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091120.092930.128953283.davem@davemloft.net>
Date:	Fri, 20 Nov 2009 09:29:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	william.allen.simpson@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH v7 6/7 RFC] TCPCT part 1f: Initiator
 Cookie => Responder

From: William Allen Simpson <william.allen.simpson@...il.com>
Date: Fri, 20 Nov 2009 09:55:45 -0500

> +	u8 cookie_size = (!tp->rx_opt.cookie_out_never && cvp != NULL)
> +			 ? tcp_cookie_size_check(cvp->cookie_desired)
> +			 : 0;

Please put the "?" and ":" and the end of the previous line not
at the beginning of the next one.
>  
> +	if (*md5 == NULL
> +	 && (OPTION_TS & opts->options)
> +	 && cookie_size > 0) {

Please fix up the coding style of this conditional.  The '&&'
belongs at the end of the previous line and the indentation is
not correct here.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html