netdev - Re: [net-next-2.6 PATCH v7 7/7 RFC] TCPCT part 1g: Responder Cookie => Initiator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091120.093147.145901642.davem@davemloft.net>
Date:	Fri, 20 Nov 2009 09:31:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	william.allen.simpson@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH v7 7/7 RFC] TCPCT part 1g: Responder
 Cookie => Initiator

From: William Allen Simpson <william.allen.simpson@...il.com>
Date: Fri, 20 Nov 2009 10:06:40 -0500

>  	/* RFC1323: H1. Apply PAWS check first. */
> -	if (tcp_fast_parse_options(skb, th, tp) && tp->rx_opt.saw_tstamp &&
> -	    tcp_paws_discard(sk, skb)) {
> +	if (tcp_fast_parse_options(skb, th, tp, &hash_location)
> +	 && tp->rx_opt.saw_tstamp
> +	 && tcp_paws_discard(sk, skb)) {

Please fix this conditional's coding style.  The '&&' belongs at
the end of the previous line not at the beginning of the next
one.  Also the indentation is not correct.

> +
> +		if (cvp != NULL
> +		 && cvp->cookie_pair_size > 0
> +		 && tp->rx_opt.cookie_plus > 0) {

Likewise.

> +	if (tmp_opt.cookie_plus > 0
> +	 && tmp_opt.saw_tstamp
> +	 && !tp->rx_opt.cookie_out_never
> +	 && (sysctl_tcp_cookie_size > 0
> +	  || (tp->cookie_values != NULL
> +	   && tp->cookie_values->cookie_desired > 0))) {

Likewise.

> +	/* Similar rationale to tcp_syn_options() applies here, too.
> +	 * If the <SYN> options fit, the same options should fit now!
> +	 */
> +	if (*md5 == NULL
> +	 && doing_ts
> +	 && cookie_plus > TCPOLEN_COOKIE_BASE) {

Likewise.

> +		if (cvp != NULL
> +		 && cvp->s_data_constant
> +		 && cvp->s_data_desired > 0) {

Likewise.

> +	if (tmp_opt.cookie_plus > 0
> +	 && tmp_opt.saw_tstamp
> +	 && !tp->rx_opt.cookie_out_never
> +	 && (sysctl_tcp_cookie_size > 0
> +	  || (tp->cookie_values != NULL
> +	   && tp->cookie_values->cookie_desired > 0))) {

Likewise.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html