netdev - Re: Diagnostic Monitoring Interface Monitoring (DOM) PATCH 4/5 for net-next-2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1259017659.16503.138.camel@Joe-Laptop.home>
Date:	Mon, 23 Nov 2009 15:07:39 -0800
From:	Joe Perches <joe@...ches.com>
To:	Robert Olsson <robert@...julf.net>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: Diagnostic Monitoring Interface Monitoring (DOM) PATCH 4/5 for
 net-next-2.6

On Mon, 2009-11-23 at 23:55 +0100, Robert Olsson wrote:
> Signed-off-by: Robert Olsson <robert.olsson@....uu.se>

Can you run ./scripts/checkpatch.pl on your patches please?

> +	if((res = read_phy_diag(hw, 0x1, DOM_A2_TEMP_SLOPE, &pd->temp_slope)))
> +		goto out;
[etc...]
> +	if((res = read_phy_diag(hw, 0x1, DOM_A2_TX_I_OFFSET, &pd->tx_bias_offset)))
> +		goto out;

perhaps this is clearer as:

	if (read_phy_diag(hw, 0x1, reg, loc) ||
	    read_phy_diag(hw, 0x1, reg2, loc2) ||
	...
	    read_phy_diag(hw, 0x1, regN, locN))
		goto out;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html