netdev - Re: [PATCH v2] ep93xx-eth: check for zero MAC address on probe, not on device open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091129.235043.101670708.davem@davemloft.net>
Date:	Sun, 29 Nov 2009 23:50:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	florian@...nwrt.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2] ep93xx-eth: check for zero MAC address on probe,
 not on device open

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Sun, 29 Nov 2009 13:11:58 +0100

> On Sun, Nov 29, 2009 at 12:57:00AM +0100, Florian Fainelli wrote:
> 
>> If we happen to have registered the driver without passing
>> a MAC address, we will print a zero MAC address and register
>> the interface with this invalid address, this is confusin. This
>> patch moves the checking of a valid ethernet address and the
>> generation of a random one down from the open function to
>> the probe function.
>> 
>> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> 
> Acked-by: Lennert Buytenhek <buytenh@...tstofly.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html