netdev - Re: [patch] drop chan->wsem on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091130074418.GC25334@fi.muni.cz>
Date:	Mon, 30 Nov 2009 08:44:18 +0100
From:	Jan Kasprzak <kas@...muni.cz>
To:	Dan Carpenter <error27@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [patch] drop chan->wsem on error path

Dan Carpenter wrote:
: The other paths all drop chan->wsem.  This was found by a static
: checker (smatch).

	You are right, thanks!

: 
: Signed-off-by: Dan Carpenter <error27@...il.com>

Acked-by: Jan "Yenya" Kasprzak <kas@...muni.cz>

: --- orig/drivers/net/wan/cosa.c	2009-11-29 16:38:42.000000000 +0200
: +++ devel/drivers/net/wan/cosa.c	2009-11-29 16:43:39.000000000 +0200
: @@ -907,6 +907,7 @@ static ssize_t cosa_write(struct file *f
:  			current->state = TASK_RUNNING;
:  			chan->tx_status = 1;
:  			spin_unlock_irqrestore(&cosa->lock, flags);
: +			up(&chan->wsem);
:  			return -ERESTARTSYS;
:  		}
:  	}

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/    Journal: http://www.fi.muni.cz/~kas/blog/ |
Please don't top post and in particular don't attach entire digests to your
mail or we'll all soon be using bittorrent to read the list.     --Alan Cox
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html