netdev - Re: [PATCH] net: release dst entry while cache-hot for GSO case too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B20AF6C.2060604@gmail.com>
Date:	Thu, 10 Dec 2009 09:21:00 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Krishna Kumar <krkumar2@...ibm.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: release dst entry while cache-hot for GSO case too

Le 10/12/2009 07:59, Krishna Kumar a écrit :
> From: Krishna Kumar <krkumar2@...ibm.com>
> 
> Non-GSO code drops dst entry for performance reasons, but
> the same is missing for GSO code. Drop dst while cache-hot
> for GSO case too.
> 
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>
> ---
> 
> diff -ruNp org/net/core/dev.c new/net/core/dev.c
> --- org/net/core/dev.c	2009-12-10 10:20:39.000000000 +0530
> +++ new/net/core/dev.c	2009-12-10 10:21:17.000000000 +0530
> @@ -1853,6 +1853,14 @@ gso:
>  
>  		skb->next = nskb->next;
>  		nskb->next = NULL;
> +
> +		/*
> +		 * If device doesnt need nskb->dst, release it right now while
> +		 * its hot in this cpu cache
> +		 */
> +		if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
> +			skb_dst_drop(nskb);
> +
>  		rc = ops->ndo_start_xmit(nskb, dev);
>  		if (unlikely(rc != NETDEV_TX_OK)) {
>  			if (rc & ~NETDEV_TX_MASK)

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html