netdev - Re: [RFC] gianfar: Fix stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B20AFA6.80706@gmail.com>
Date:	Thu, 10 Dec 2009 09:21:58 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Kumar Gopalpet-B05799 <B05799@...escale.com>
CC:	netdev@...r.kernel.org, avorontsov@...mvista.com,
	davem@...emloft.net
Subject: Re: [RFC] gianfar: Fix stats support

Le 10/12/2009 08:43, Kumar Gopalpet-B05799 a écrit :
>  
>> Fine by me, but if this patch is for linux-2.6.33, you can use 
>> dev_txq_stats_fold() helper in your gfar_get_stats()
>>
>> dev_txq_stats_fold(dev, &dev->stats);
>> return &dev->stats;
>>
> 
> Eric, the problem in using dev_txq_stats_fold() will be that
> txq->tx_dropped will not be updated. tx_dropped counter is updated on a
> device level in the gfar_error( ) interrupt context (here we do not know
> the txq index).
> So, if we use dev_txq_stats_fold(), we will incorrectly give the
> tx_dropped stats.

Ah yes, you are very right, thanks !
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html