netdev - Re: [net-2.6 PATCH 2/3] ixgbe: Fix tx_restart_queue/non_eop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091213.191804.226782424.davem@davemloft.net>
Date:	Sun, 13 Dec 2009 19:18:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	mallikarjuna.chilakala@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-2.6 PATCH 2/3] ixgbe: Fix tx_restart_queue/non_eop_desc
 statistics counters

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 11 Dec 2009 23:51:41 -0800

> @@ -4528,10 +4529,12 @@ void ixgbe_update_stats(struct ixgbe_adapter *adapter)
>  
>  	/* gather some stats to the adapter struct that are per queue */
>  	for (i = 0; i < adapter->num_tx_queues; i++)
> -		adapter->restart_queue += adapter->tx_ring[i].restart_queue;
> +		restart_queue += adapter->tx_ring[i]->restart_queue;
> +	adapter->restart_queue = restart_queue;

I don't see how these two versions of the code can behave
differently unless there is very broken locking on the
adapter->* statistic counters.

I'm not applying this without at least a better commit
log message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html