netdev - Re: [net-2.6 PATCH 2/3] ixgbe: Fix tx_restart_queue/non_eop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091213.210706.258124695.davem@davemloft.net>
Date:	Sun, 13 Dec 2009 21:07:06 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, mallikarjuna.chilakala@...el.com
Subject: Re: [net-2.6 PATCH 2/3] ixgbe: Fix tx_restart_queue/non_eop_desc
 statistics counters

From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Date: Sun, 13 Dec 2009 20:57:05 -0800

> On Sun, 2009-12-13 at 19:18 -0800, David Miller wrote:
>> I don't see how these two versions of the code can behave
>> differently unless there is very broken locking on the
>> adapter->* statistic counters.
> 
> The problem is the adapter->restart_queue is being double-counted.  If
> we accumulate from each ring's restart_queue, which are cumulative, then
> we don't want to add it to the previous update_stats() values in
> adapter->restart_queue.

Now I understand, thanks.

>> I'm not applying this without at least a better commit
>> log message.
> 
> We can fix the commit log message to better explain what the problem is.

Thanks PJ.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html