netdev - Re: [net-2.6 PATCH 3/3] Fix 82598 premature copper PHY link indicatation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7991c5480912141037u77cc4988qee734feb555e4ba5@mail.gmail.com>
Date:	Mon, 14 Dec 2009 10:37:32 -0800
From:	Malli <mchilakala@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, mallikarjuna.chilakala@...el.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-2.6 PATCH 3/3] Fix 82598 premature copper PHY link 
	indicatation

Thanks Dave. I'll respin the patch, didn't mean to wait in non-preemptive loop.

On Sun, Dec 13, 2009 at 7:18 PM, David Miller <davem@...emloft.net> wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Fri, 11 Dec 2009 23:52:01 -0800
>
>> +     for (timeout = 0;
>> +          timeout < IXGBE_VALIDATE_LINK_READY_TIMEOUT; timeout++) {
>> +             hw->phy.ops.read_reg(hw, MDIO_STAT1, MDIO_MMD_AN, &an_reg);
>> +
>> +             if ((an_reg & MDIO_AN_STAT1_COMPLETE) &&
>> +                 (an_reg & MDIO_STAT1_LSTATUS))
>> +                     break;
>> +
>> +             mdelay(100);
>> +     }
>
> An up to 5000 msec non-preemptable spin loop.
>
> If this used "msleep()" that would make it OK.
>
> But as it is, sorry, no way.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html