netdev - Re: [PATCH] net: sh_eth alignment fix for sh7724 using NET_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec7e5c30912142328l77efbb22rc5bdc45dc897f781@mail.gmail.com>
Date:	Tue, 15 Dec 2009 16:28:31 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, lethal@...ux-sh.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] net: sh_eth alignment fix for sh7724 using NET_IP_ALIGN

On Tue, Dec 15, 2009 at 4:22 PM, Magnus Damm <magnus.damm@...il.com> wrote:
> On Tue, Dec 15, 2009 at 4:15 PM, David Miller <davem@...emloft.net> wrote:
>> NET_IP_ALIGN is never != 2 on SUPERH
>>
>> SH_ETH depends on SUPERH
>>
>> It's a fantasy ifdef, of sorts. :-)
>
> Sure, but _maybe_ someone will put the sh_eth hardware block together
> with MIPS or ARM in the future. I guess it makes more sense to just
> use the NET_IP_ALIGN value blindly and not care so much about what is
> known working and what is not...?

Well, it's in the sh7724 specific portion of the code and I guess
that's SUPERH. =)

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html