netdev - RE: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9F4C7D19E8361D4C94921B95BE08B81BA08D5A@zin33exm22.fsl.freescale.net>
Date:	Wed, 16 Dec 2009 10:34:56 +0530
From:	"Kumar Gopalpet-B05799" <B05799@...escale.com>
To:	"Roel Kluin" <roel.kluin@...il.com>, <netdev@...r.kernel.org>,
	"David Miller" <davem@...emloft.net>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"LKML" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse_group()

 
>Won't it be better to change types of interruptTransmit, 
>-Receive and -Error in  struct gfar_priv_grp itself. Something 
>like this:
>
>struct gfar_priv_grp {
>....
>-	unsigned int interruptTransmit;
>-	unsigned int interruptReceive;
>-	unsigned int interruptError;
>
>+	unsigned int interruptTransmit;
>+	unsigned int interruptReceive;
>+	unsigned int interruptError;
>....
>}
>

Sorry for my earlier mail, What I meant is something like this:

struct gfar_priv_grp {
....
-	unsigned int interruptTransmit;
-	unsigned int interruptReceive;
-	unsigned int interruptError;

+	int interruptTransmit;
+	int interruptReceive;
+	int interruptError;
....
}

--

Thanks
Sandeep
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html