netdev - Re: [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091215.231855.107696050.davem@davemloft.net>
Date:	Tue, 15 Dec 2009 23:18:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	mallikarjuna.chilakala@...el.com, peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-2.6 PATCH v2 1/2] ixgbe: Fix
 tx_restart_queue/non_eop_desc statistics counters

From: David Miller <davem@...emloft.net>
Date: Tue, 15 Dec 2009 23:16:51 -0800 (PST)

> From: David Miller <davem@...emloft.net>
> Date: Tue, 15 Dec 2009 21:13:54 -0800 (PST)
> 
>> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> Date: Tue, 15 Dec 2009 13:56:59 -0800
>> 
>>> From: Mallikarjuna R Chilakala <mallikarjuna.chilakala@...el.com>
>>> 
>>> Fix the restart_queue and non_eop_desc counters from being
>>> double-counted.  They are cumulative in each ring, so we don't want to
>>> add them to the cumulative result in the adapter's master counter.
>>> Otherwise, the stats will be inaccurate
>>> 
>>> Signed-off-by:  Mallikarjuna R Chilakala <mallikarjuna.chilakala@...el.com>
>>> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> 
>> Applied.
> 
> So how did you build test this?
> 
> drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_update_stats’:
> drivers/net/ixgbe/ixgbe_main.c:4532: error: invalid type argument of ‘->’ (have ‘struct ixgbe_ring’)
> drivers/net/ixgbe/ixgbe_main.c:4536: error: invalid type argument of ‘->’ (have ‘struct ixgbe_ring’)

I'm making the obvious fix "s/->/./", but really....