netdev - RE: [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6A821A2E197F6E4C85FD3440E8AFAD3E61A649CBAA@rrsmsx501.amr.corp.intel.com>
Date:	Wed, 16 Dec 2009 09:29:05 -0700
From:	"Chilakala, Mallikarjuna" <mallikarjuna.chilakala@...el.com>
To:	David Miller <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Subject: RE: [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop_desc
 statistics counters



>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Tuesday, December 15, 2009 11:19 PM
>To: Kirsher, Jeffrey T
>Cc: netdev@...r.kernel.org; gospo@...hat.com; Chilakala, Mallikarjuna;
>Waskiewicz Jr, Peter P
>Subject: Re: [net-2.6 PATCH v2 1/2] ixgbe: Fix tx_restart_queue/non_eop_desc
>statistics counters
>
>From: David Miller <davem@...emloft.net>
>Date: Tue, 15 Dec 2009 23:16:51 -0800 (PST)
>
>> From: David Miller <davem@...emloft.net>
>> Date: Tue, 15 Dec 2009 21:13:54 -0800 (PST)
>>
>>> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>>> Date: Tue, 15 Dec 2009 13:56:59 -0800
>>>
>>>> From: Mallikarjuna R Chilakala <mallikarjuna.chilakala@...el.com>
>>>>
>>>> Fix the restart_queue and non_eop_desc counters from being
>>>> double-counted.  They are cumulative in each ring, so we don't want to
>>>> add them to the cumulative result in the adapter's master counter.
>>>> Otherwise, the stats will be inaccurate
>>>>
>>>> Signed-off-by:  Mallikarjuna R Chilakala
><mallikarjuna.chilakala@...el.com>
>>>> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
>>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>>>
>>> Applied.
>>
>> So how did you build test this?
>>
>> drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_update_stats’:
>> drivers/net/ixgbe/ixgbe_main.c:4532: error: invalid type argument of ‘->’
>(have ‘struct ixgbe_ring’)
>> drivers/net/ixgbe/ixgbe_main.c:4536: error: invalid type argument of ‘->’
>(have ‘struct ixgbe_ring’)
>
>I'm making the obvious fix "s/->/./", but really....

Thanks Dave for fixing the issue, some changes in Jeff's GIT tree
has created this merge issue. Most likely the order of patches that were
send out might have created this problem.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html